Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: augment vue rather than @vue/runtime-core #217

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

danielroe
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In line with vuejs/router#2295 and nuxt/nuxt#28542, this moves to augment vue rather than @vue/runtime core.

This is now officially recommended in the docs and it must be done by all libraries or it will break types for other libraries.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

src/types/instance.ts Outdated Show resolved Hide resolved
@BobbieGoede
Copy link
Member

Thanks! We'll find out later if @vue/runtime-dom needs changing as well πŸ˜…

@BobbieGoede BobbieGoede merged commit eb7c01d into vueuse:main Aug 16, 2024
5 checks passed
@danielroe danielroe deleted the vue-augment branch August 16, 2024 13:54
@matteoscaramuzza
Copy link

When is planned to release a new version that will include this fix?
Because I'd like to fix this problem in our component library, but without this fix there are some problems with builds.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants