Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sparse binding support #2609

Merged
merged 18 commits into from
Feb 3, 2025
Merged

Add sparse binding support #2609

merged 18 commits into from
Feb 3, 2025

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Nov 29, 2024 •
edited
Loading

Changelog:

### Breaking changes
Changes to images:
- `ImageMemory::Sparse` no longer has a field for memory requirements, this is now queried directly from the image.

### Additions
- Support for sparse binding.

Closes #2360, closes #537.

@Rua Rua mentioned this pull request Nov 29, 2024
Closed
LDeakin
LDeakin reviewed Nov 30, 2024
View reviewed changes
Copy link
Contributor

@LDeakin LDeakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @Rua! I've tested this with sparse partially resident images and it worked great 👍

vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
@Rua Rua marked this pull request as ready for review November 30, 2024 10:11
@Rua
Copy link
Contributor Author

Rua commented Nov 30, 2024

This is ready for review now.

marc0246
marc0246 reviewed Jan 28, 2025
View reviewed changes
vulkano/src/image/sys.rs Outdated Show resolved Hide resolved
vulkano/src/image/sys.rs Outdated Show resolved Hide resolved
vulkano/src/buffer/sys.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
@marc0246
Copy link
Contributor

There's a typo here (2_3 -> 2_d):

vulkano/vulkano/src/image/mod.rs

Line 1018 in ab464bc

/// [`sparse_residency_image2_3`]: crate::device::DeviceFeatures::sparse_residency_image3_d

marc0246
marc0246 reviewed Feb 2, 2025
View reviewed changes
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
vulkano/src/memory/sparse.rs Outdated Show resolved Hide resolved
@marc0246
Copy link
Contributor

marc0246 commented Feb 2, 2025

There is no validation for offset + extent being in range of the image's extent (because there are no VUIDs :ferrisCluelesser:)

@marc0246
Copy link
Contributor

marc0246 commented Feb 2, 2025

Are we sure about the Sparse info structs being exhaustive?

@marc0246
Copy link
Contributor

marc0246 commented Feb 3, 2025

🎉

@marc0246 marc0246 merged commit fbbcee9 into vulkano-rs:master Feb 3, 2025
6 checks passed
marc0246 added a commit that referenced this pull request Feb 3, 2025
@marc0246
#2609 changelog
898db92
@Rua Rua deleted the sparse branch February 3, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc0246 marc0246 marc0246 left review comments

@LDeakin LDeakin LDeakin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support sparse binding Feature support for sparse residency multisampled images is not checked
3 participants
@Rua @marc0246 @LDeakin