sockeqwe#65 taking into account isChangingConfig()

build.gradle

@@ -50,5 +50,6 @@ ext {
   // Test Libs
   robolectricVersion = '2.4'
   junitVersion = '4.12'
-  mockitoVersion = '1.9.5'
+  mockitoVersion = '2.0.5-beta'
+  powermockVersion = '1.6.2'
 }

mvp/build.gradle

@@ -43,4 +43,14 @@ dependencies {
 
   testCompile 'junit:junit:' + rootProject.ext.junitVersion
   testCompile 'org.mockito:mockito-core:' + rootProject.ext.mockitoVersion
+
+
+  testCompile ('org.powermock:powermock-api-mockito:'+rootProject.ext.powermockVersion) {
+    exclude module: 'hamcrest-core'
+    exclude module: 'objenesis'
+  }
+  testCompile ('org.powermock:powermock-module-junit4:'+rootProject.ext.powermockVersion) {
+    exclude module: 'hamcrest-core'
+    exclude module: 'objenesis'
+  }
 }

mvp/src/main/java/com/hannesdorfmann/mosby/mvp/MvpFragment.java

@@ -20,6 +20,7 @@
 import android.os.Bundle;
 import android.support.annotation.NonNull;
 import android.support.annotation.Nullable;
+import android.support.v4.app.FragmentActivity;
 import android.view.View;
 import com.hannesdorfmann.mosby.MosbyFragment;
 import com.hannesdorfmann.mosby.mvp.delegate.FragmentMvpDelegateImpl;
@@ -82,7 +83,8 @@ public abstract class MvpFragment<V extends MvpView, P extends MvpPresenter<V>>
   }
 
   @Override public boolean isRetainingInstance() {
-    return getRetainInstance();
+    FragmentActivity activity = getActivity();
+    return getRetainInstance() && activity != null && activity.isChangingConfigurations();
   }
 
   @NonNull @Override public V getMvpView() {

mvp/src/main/java/com/hannesdorfmann/mosby/mvp/delegate/MvpDelegateCallback.java

@@ -16,6 +16,7 @@
 
 package com.hannesdorfmann.mosby.mvp.delegate;
 
+import android.app.Activity;
 import com.hannesdorfmann.mosby.mvp.MvpPresenter;
 import com.hannesdorfmann.mosby.mvp.MvpView;
 
@@ -64,7 +65,8 @@ public interface MvpDelegateCallback<V extends MvpView, P extends MvpPresenter<V
 
   /**
    * Is the view retaining? This boolean flag is used for {@link MvpPresenter#detachView(boolean)}
-   * as parameter.
+   * as parameter. Usually you should take {@link Activity#isChangingConfigurations()} into
+   * account.
    *
    * @return true if the view is retaining, hence the presenter should be retaining as well.
    */

mvp/src/test/java/com/hannesdorfmann/mosby/mvp/MvpFragmentTest.java

@@ -0,0 +1,79 @@
+/*
+ *  Copyright 2015 Hannes Dorfmann.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package com.hannesdorfmann.mosby.mvp;
+
+import android.support.v4.app.FragmentActivity;
+import junit.framework.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mockito;
+import org.powermock.api.mockito.PowerMockito;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+/**
+ * @author Hannes Dorfmann
+ */
+
+@RunWith(PowerMockRunner.class) @PrepareForTest(MvpFragment.class)
+public class MvpFragmentTest {
+
+  private MvpFragment<MvpView, MvpPresenter<MvpView>> fragment;
+  private FragmentActivity activity;
+
+  @Before public void init() {
+
+    activity = Mockito.mock(FragmentActivity.class);
+    fragment = PowerMockito.spy(new MvpFragment<MvpView, MvpPresenter<MvpView>>() {
+      @Override public MvpPresenter<MvpView> createPresenter() {
+        return null;
+      }
+    });
+  }
+
+  @Test public void retainingAndActivityNull() {
+    PowerMockito.when(fragment.getRetainInstance()).thenReturn(true);
+    PowerMockito.when(fragment.getActivity()).thenReturn(null);
+
+    Assert.assertFalse(fragment.isRetainingInstance());
+  }
+
+  @Test public void notRetainingAndActivityNull() {
+    PowerMockito.when(fragment.getRetainInstance()).thenReturn(false);
+    PowerMockito.when(fragment.getActivity()).thenReturn(null);
+
+    Assert.assertFalse(fragment.isRetainingInstance());
+  }
+
+  @Test public void retainingAndNotChangingConfig() {
+    PowerMockito.when(fragment.getRetainInstance()).thenReturn(true);
+    PowerMockito.when(activity.isChangingConfigurations()).thenReturn(false);
+
+    Assert.assertFalse(fragment.isRetainingInstance());
+  }
+
+  @Test public void retainingAndChangingConfig() {
+
+    PowerMockito.when(fragment.getActivity()).thenReturn(activity);
+    PowerMockito.when(fragment.getRetainInstance()).thenReturn(true);
+    PowerMockito.when(activity.isChangingConfigurations()).thenReturn(true);
+
+    Assert.assertTrue(fragment.isRetainingInstance());
+  }
+}

viewstate/build.gradle

@@ -29,7 +29,7 @@ android {
 dependencies {
   compile project(':mvp')
 
-  testCompile 'org.robolectric:robolectric:'+ rootProject.ext.robolectricVersion
   testCompile 'junit:junit:' + rootProject.ext.junitVersion
-  testCompile 'org.mockito:mockito-core:1.9.5'
+  testCompile 'org.mockito:mockito-core:' + rootProject.ext.mockitoVersion
+  testCompile 'org.robolectric:robolectric:'+ rootProject.ext.robolectricVersion
 }