-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure runs unit tests #174
Conversation
01e9f22
to
1eb1b58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some feedback to help guide the future work.
18228aa
to
1352804
Compare
90a3ea6
to
97da2ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some random detail oriented comments.
f7efab6
to
9e0b125
Compare
Thx for all this! the one additional test I'd like to see is:
|
30b3204
to
2c11bfd
Compare
run_status_id: runStatus.id | ||
}); | ||
|
||
const activeRuns = await RunService.configureRuns({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spectranaut here's the test!
3dc5c84
to
49b7d89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good to me!
No description provided.