Executing Test: Tester View: Test Conflict Resolution, Pt 1 #94

rwaldron · 2020-05-19T20:39:14Z

Run yarn db-migrate:dev
Run yarn
Run yarn dev
Note that when running from dev configuration, your issues will be created here: https://github.com/bocoup/aria-at/issues.
Open the app at http://localhost:3000
Sign out of the app
In another tab, go here: https://github.com/settings/applications, and revoke your authentication for "ARIA-AT Report API (Development)"
Return to the app and click "Sign in with Github"
Authorize
Once back at the app, make sure you have some ATs set up.
Go to http://localhost:3000/cycles, click "Initiate"
Create a "Test Cycle Configuration"
Check the checkboxes and assign yourself to each of the
Test Plans"
Click "Initiate Cycle"
Go to http://localhost:3000/test-queue
Click "Contribute Tests"
Click the name of any "Test Plan". If none are clickable, click "Assign Me" then click the name.
You're now in the test and can actually start testing this feature 🙄

Observe that there are no Status notifications on the page.
Click "Raise an issue", observe that you are now at the "Create an issue" prompt.
Observe there is a form and two buttons: "Cancel" and "Submit new issue"
Click "Cancel". Observe that the prompt closes.
Click "Raise an issue", observe that you are now at the "Create an issue" prompt.
Make any changes you want and click "Submit new issue"
Observe that you are now at the "Issue created" view and are presented with a message that says "Issue #XX created" where "XX" is the issue number that was created. Click "Done", observe that the prompt closes.
Click "Raise an issue", observe that you are now at the "Review existing issues
" prompt, and shown a list that has your issue in it.
Click "My issue exists in this list", observe that the prompt closes.
Click "Raise an issue"
Click "My issue is not in this list", observe that you are at the "Create an issue" prompt.
Click "Back to issues list", observe that you are at the "Review existing issues
" prompt.
Click the "X" in the upper right of the prompt.
Refresh the test page
Observe that there is now a "status bar" that says "This test has open issues"
Click the "Review issues" button, observe that you are now at the "Review existing issues" prompt.
Scroll to the "See on github.com" link and click it.
Close the issue on Github
Return to the ARIA-AT test page and refresh.
Observe that the status bar is gone.
Click "Raise an issue", observe that you are now at the "Create an issue" prompt.

spectranaut · 2020-05-20T17:38:55Z

I reported an issue on the first test, and I see it in the bocoup/aria-at fork. Then I went to the next test, and the next test, and they all have "This test has an open issue banner", and if you click on it, you see this:

spectranaut

I think the next thing I need to work on is identifying conflicts, in which case, I'm inclined to just merge this PR and work on top of it. My main issues are with the workflow and that I think your stump'ed function calls don't need to exist, so I can just remove them in my work.

spectranaut · 2020-05-20T18:00:26Z

client/components/DisplayTest/index.jsx

-                    </Button>
-                </Modal.Footer>
-            </Modal>
+            <>


omg, what is this? replacement for fragment?

spectranaut · 2020-05-20T18:40:15Z

client/actions/cycles.js

+ * @param  {Number} cycle_id    The id of the cycle to retrieve conflicts
+ * @return {Array}              An array of conflict objects.
+ */
+export function getConflictsByCycleId(cycle_id) {


We actually don't need this. All the results for a cycle are already in the front end -- so we can do the conflict calculation on the front end.

As it is right now, having all test results for all test for a cycle when you contribute to a cycle -- might seems a little heavy handed.. but for now it is not too much data. we might need to later serve things in smaller pieces.

We might be thinking of something different here. The conflicts/diffs that @s3ththompson and I planned out are based on a serialization of the actual form itself within the iframe. That would also be used to repopulate those forms the next time you open the test to run it. The current data that I saw in the result objects does not have the details necessary to do that.

i think the issue is that there are 2 concepts here with similar terminology. here's my conception of them, hopefully it matches yours?

[1] the results conflict diff, which Matt sketched out, which will go at the bottom of the GitHub issue, which Val points out can be generated on the frontend.

[2] the (basically) vdom state that will need to be serialized from the iframe form, saved to the db, and then retrieved to re-hydrate the form during editing.

@rwaldron it sounds like this stub is for [2]? if so, is it appropriately named? don't we need to save the serialized data for all results, whether it's conflicted or not?

@s3ththompson yes, you're correct. @spectranaut and I had a call to discuss this and I described our idea and she's got it now.

spectranaut · 2020-05-20T18:41:35Z

client/actions/cycles.js

+ * @param  {Number} cycle_id    The id of the cycle to retrieve results
+ * @return {Array}              An array of result objects.
+ */
+export function getResultsByCycleId(cycle_id) {


Same as above, we have all this data.

client/components/StatusBar/index.jsx

- Executing Test: Tester View: Status Bar - API request new GitHub issue on backend, save ID, and redirect - Query GitHub Issue ID for status on view test

…ixes

s3ththompson · 2020-05-21T13:01:56Z

server/migrations/20200521003201-create_table_test_issues.js

+            issue_number: {
+                type: Sequelize.INTEGER,
+                allowNull: false
+            }


I think you may be missing the open boolean column?

I just got an error about this @s3ththompson , I'll push a commit...

s3ththompson · 2020-05-21T13:10:04Z

server/models/TestIssue.js

+            },
+            open: {
+                type: BOOLEAN,
+                allowNull: true


I believe boolean false is not null, so allowNull can be false for consistency / safety.

rwaldron requested review from spectranaut, s3ththompson and evmiguel May 19, 2020 20:39

rwaldron force-pushed the raise-issue-status branch 11 times, most recently from 9c33bc3 to 6ef1c2e Compare May 20, 2020 16:03

spectranaut requested changes May 20, 2020

View reviewed changes

rwaldron force-pushed the raise-issue-status branch 4 times, most recently from e5c5845 to 747a61e Compare May 21, 2020 01:14

rwaldron added 4 commits May 20, 2020 21:18

Executing Test: Tester View: Test Conflict Resolution, Pt 1

480ef66

- Executing Test: Tester View: Status Bar - API request new GitHub issue on backend, save ID, and redirect - Query GitHub Issue ID for status on view test

Executing Test: Tester View: Test Conflict Resolution, Pt 1, review f…

ad332a1

…ixes

Migration: create_table_test_issues

5cf3700

Add GITHUB_REPO_ID GITHUB_REPO_OWNER GITHUB_REPO_NAME to staging config

e1a3281

rwaldron force-pushed the raise-issue-status branch from 747a61e to e1a3281 Compare May 21, 2020 01:19

Lint fix

0037456

s3ththompson requested changes May 21, 2020

View reviewed changes

s3ththompson reviewed May 21, 2020

View reviewed changes

rwaldron and others added 2 commits May 21, 2020 11:39

TestIssue: remove "open" from model

66b59a5

Linter

c212923

spectranaut merged commit cebed5c into main May 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Executing Test: Tester View: Test Conflict Resolution, Pt 1 #94

Executing Test: Tester View: Test Conflict Resolution, Pt 1 #94

rwaldron commented May 19, 2020 •

edited

Loading

spectranaut commented May 20, 2020

spectranaut left a comment

spectranaut May 20, 2020

rwaldron May 20, 2020

spectranaut May 20, 2020

rwaldron May 20, 2020

s3ththompson May 20, 2020

rwaldron May 20, 2020

spectranaut May 20, 2020

s3ththompson May 21, 2020

spectranaut May 21, 2020

s3ththompson May 21, 2020

Executing Test: Tester View: Test Conflict Resolution, Pt 1 #94

Executing Test: Tester View: Test Conflict Resolution, Pt 1 #94

Conversation

rwaldron commented May 19, 2020 • edited Loading

spectranaut commented May 20, 2020

spectranaut left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwaldron commented May 19, 2020 •

edited

Loading