Minor changes to width/height config members. #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For VideoDecoderConfig, the coded size attributes are no longer required. They only serve as a hint for the UA to create an approriate underlying decoder (e.g. hardware accelerated for higher resolutions) and are not strictly required. Fixes #94. For VideoEncoderConfig, cropWidth and cropHeight are renamed to simply be width and height. The crop prefix was added in #113 as I realized that we were describing the "crop" size of the encoded VideoFrames. But I now think this risks giving the impression that the encoder is going to crop frames. Being intuitive is more important than being pedantic.
aboba
approved these changes
Apr 21, 2021
|
@padenot I'll go ahead and land this very minor edit w/ just Bernard's approval. Happy to address any feedback you may have in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For VideoDecoderConfig, the coded size attributes are no longer
required. They only serve as a hint for the UA to create an approriate
underlying decoder (e.g. hardware accelerated for higher resolutions)
and are not strictly required. Fixes #94.
For VideoEncoderConfig, cropWidth and cropHeight are renamed to simply
be width and height. The crop prefix was added in #113 as I realized
that we were describing the "crop" size of the encoded VideoFrames. But
I now think this risks giving the impression that the encoder is going
to crop frames. Being intuitive is more important than being pedantic.
Preview | Diff