Skip to content

Commit

Permalink
[9.x] Enable PHP 8.2 tests for Ably (laravel#44144)
Browse files Browse the repository at this point in the history
* Update AblyBroadcasterTest.php

* Update AblyBroadcasterTest.php
  • Loading branch information
driesvints authored Sep 15, 2022
1 parent d00f8df commit bed5e03
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions tests/Broadcasting/AblyBroadcasterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ class AblyBroadcasterTest extends TestCase

protected function setUp(): void
{
if (phpversion() >= '8.2') {
$this->markTestSkipped('Tests are broken on PHP 8.2');
}

parent::setUp();

$this->ably = m::mock(AblyRest::class, ['abcd:efgh']);
Expand Down Expand Up @@ -126,8 +122,7 @@ public function testAuthThrowAccessDeniedHttpExceptionWithPresenceChannelWhenReq
protected function getMockRequestWithUserForChannel($channel)
{
$request = m::mock(Request::class);
$request->channel_name = $channel;
$request->socket_id = 'abcd.1234';
$request->shouldReceive('all')->andReturn(['channel_name' => $channel, 'socket_id' => 'abcd.1234']);

$request->shouldReceive('input')
->with('callback', false)
Expand All @@ -152,7 +147,7 @@ protected function getMockRequestWithUserForChannel($channel)
protected function getMockRequestWithoutUserForChannel($channel)
{
$request = m::mock(Request::class);
$request->channel_name = $channel;
$request->shouldReceive('all')->andReturn(['channel_name' => $channel]);

$request->shouldReceive('user')
->andReturn(null);
Expand Down

0 comments on commit bed5e03

Please sign in to comment.