Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Custom providers drawer design update #3892

Merged

Conversation

m-rgba
Copy link
Contributor

@m-rgba m-rgba commented Mar 18, 2025

Description

Design update for custom AI provider drawer.

Before After
CleanShot 2025-03-18 at 13 24 21 CleanShot 2025-03-24 at 08 32 45
  • ToDo: Need to update with docs link in the callout when we're ready to publish.
  • Updated header area for height and font weight.
  • Updated font to use Source Sans Pro / made typography feel right.
  • Updated spacing between form elements.
  • Made some tweaks to padding and sizing to prevent page overflow when the screen is short.
  • Updated padding around the form.
  • Adjusted button sizes on the clear buttons to match the inline inputs.
  • Added a sample endpoint description to the base URL field.
  • Made buttons full width - added submit / edit logic to the text.

Functional changes:

  • Used the ResizeablDrawer cause we should probably center around using those for most of these non-peek drawers.
  • Added default header and model rows to save on an action for adding a new row.
  • Stripped empty headers (similar to the stripping model logic).
  • Stripped the trailing / for the baseURL onSubmit (cause I do that all the time other places when I'm setting up custom models and it's annoying to debug).

@m-rgba m-rgba changed the title Custom providers design update Custom providers drawer design update Mar 18, 2025
Copy link
Contributor

github-actions bot commented Mar 18, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@m-rgba m-rgba changed the title Custom providers drawer design update chore(ui): Custom providers drawer design update Mar 18, 2025
@m-rgba m-rgba marked this pull request as ready for review March 18, 2025 17:28
@m-rgba m-rgba requested review from a team as code owners March 18, 2025 17:28
</Typography>
<TextField
placeholder="Enter API key name"
placeholder="Enter API key / token..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im worried this might be confusing,
i used name because putting the token itself here doesnt work
you have to put the name and then add the name and token to the team secrets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jwlee64 - updated with a callout about the OpenAI compatible endpoint and more clarity around the API secret stuff. Have a look and let me know what you think.

@m-rgba
Copy link
Contributor Author

m-rgba commented Mar 24, 2025

@jwlee64 jwlee64 changed the base branch from custom-providers-pg to add-custom-providers March 24, 2025 16:15
@jwlee64 jwlee64 changed the base branch from add-custom-providers to custom-providers-pg March 24, 2025 16:16
@jwlee64 jwlee64 changed the base branch from custom-providers-pg to josiah/add-custom-providers-playground March 25, 2025 06:24
@jwlee64 jwlee64 merged commit 15f1d11 into josiah/add-custom-providers-playground Mar 25, 2025
17 checks passed
@jwlee64 jwlee64 deleted the custom-providers-design-update branch March 25, 2025 06:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants