Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(weave): download dataset with images in rows in parallel #3939

Merged
merged 5 commits into from
Mar 24, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
less aggro
gtarpenning committed Mar 24, 2025
commit 9eaccd6d9ec1639b92fed4cc8ce2b86638357f38
3 changes: 2 additions & 1 deletion weave/trace/vals.py
Original file line number Diff line number Diff line change
@@ -497,7 +497,8 @@ def _remote_iter(self) -> Generator[dict, None, None]:

def process_row(val: Any, new_ref: RefWithExtra) -> Any:
if not self.table_ref:
raise ValueError("No table ref found")
# Should never happen, we need table_ref to remote_iter
return None
return make_trace_obj(
from_json(val, self.table_ref.project_id, self.server),
new_ref,