Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weave): Add custom providers table to providers tab #3956

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

jwlee64
Copy link
Contributor

@jwlee64 jwlee64 commented Mar 25, 2025

Description

Screen.Recording.2025-03-25.at.8.44.11.AM.mov

Testing

How was this PR tested?

@jwlee64 jwlee64 requested review from a team as code owners March 25, 2025 06:11
@circle-job-mirror
Copy link

circle-job-mirror bot commented Mar 25, 2025

@jwlee64 jwlee64 force-pushed the josiah/add-custom-providers-table branch from a54b4aa to 30ec943 Compare March 25, 2025 16:14
<ResizableDrawer
open={isOpen}
onClose={handleClose}
// if the navbar is visible, we need to offset the drawer by the height of the navbar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if this is applicable in other cases of the drawer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i checked at least for the calls table, but we scroll the table not the whole page in most cases

@jwlee64 jwlee64 merged commit 026749e into master Mar 26, 2025
135 checks passed
@jwlee64 jwlee64 deleted the josiah/add-custom-providers-table branch March 26, 2025 01:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants