Remove @group annotations

Summary: I'm pretty sure that `@group` annotations are useless now... I believe that they were originally used by Diviner? Test Plan: Eye-balled it. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin, aurelijus Differential Revision: https://secure.phabricator.com/D9855
wanthings · Jul 8, 2014 · d09beeb · d09beeb
1 parent b09d21d
commit d09beeb
Show file tree

Hide file tree

Showing 123 changed files with 345 additions and 573 deletions.
diff --git a/scripts/__init_script__.php b/scripts/__init_script__.php
@@ -11,7 +11,6 @@
  * When looking in these places, we expect to find a 'libphutil/' directory.
  */
 function arcanist_adjust_php_include_path() {
-
   // The 'arcanist/' directory.
   $arcanist_dir = dirname(dirname(__FILE__));
 

diff --git a/src/configuration/ArcanistConfiguration.php b/src/configuration/ArcanistConfiguration.php
@@ -17,7 +17,6 @@
  *    - add new flags to existing workflows by overriding
  *      getCustomArgumentsForCommand().
  *
- * @group config
  * @concrete-extensible
  */
 class ArcanistConfiguration {
@@ -65,8 +64,11 @@ public function willRunWorkflow($command, ArcanistBaseWorkflow $workflow) {
     // This is a hook.
   }
 
-  public function didRunWorkflow($command, ArcanistBaseWorkflow $workflow,
-                                 $err) {
+  public function didRunWorkflow(
+    $command,
+    ArcanistBaseWorkflow $workflow,
+    $err) {
+
     // This is a hook.
   }
 

diff --git a/src/configuration/ArcanistConfigurationManager.php b/src/configuration/ArcanistConfigurationManager.php
@@ -2,8 +2,6 @@
 
 /**
  * This class holds everything related to configuration and configuration files.
- *
- * @group config
  */
 final class ArcanistConfigurationManager {
 

diff --git a/src/configuration/ArcanistSettings.php b/src/configuration/ArcanistSettings.php
@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @group config
- */
 final class ArcanistSettings {
 
   private function getOptions() {
@@ -167,7 +164,7 @@ private function getOptions() {
         'type' => 'bool',
         'help' =>
           'Whether arc should permit the automatic stashing of changes in '.
-          'the working directory when requiring a clean working copy.  '.
+          'the working directory when requiring a clean working copy. '.
           'This option should only be used when users understand how '.
           'to restore their working directory from the local stash if '.
           'an Arcanist operation causes an unrecoverable error.',
@@ -329,5 +326,4 @@ public function formatConfigValueForDisplay($key, $value) {
     return $value;
   }
 
-
 }
diff --git a/src/configuration/__tests__/ArcanistBritishTestCase.php b/src/configuration/__tests__/ArcanistBritishTestCase.php
@@ -56,7 +56,6 @@ private function assertCommandCompletion($expect, $input, $commands) {
       "Correction of {$input} against: {$commands}");
   }
 
-
   public function testArgumentCompletion() {
     $this->assertArgumentCompletion(
       array('nolint'),

diff --git a/src/difference/ArcanistDiffUtils.php b/src/difference/ArcanistDiffUtils.php
@@ -2,8 +2,6 @@
 
 /**
  * Dumping ground for diff- and diff-algorithm-related miscellany.
- *
- * @group diff
  */
 final class ArcanistDiffUtils {
 

diff --git a/src/difference/__tests__/ArcanistDiffUtilsTestCase.php b/src/difference/__tests__/ArcanistDiffUtilsTestCase.php
@@ -2,71 +2,70 @@
 
 /**
  * Test cases for @{class:ArcanistDiffUtils}.
- *
- * @group testcase
  */
 final class ArcanistDiffUtilsTestCase extends ArcanistTestCase {
+
   public function testLevenshtein() {
     $tests = array(
       array(
         'a',
         'b',
-        'x'
+        'x',
       ),
       array(
         'kalrmr(array($b))',
         'array($b)',
-        'dddddddssssssssds'
+        'dddddddssssssssds',
       ),
       array(
         'array($b)',
         'kalrmr(array($b))',
-        'iiiiiiissssssssis'
+        'iiiiiiissssssssis',
       ),
       array(
         'zkalrmr(array($b))z',
         'xarray($b)x',
-        'dddddddxsssssssssdx'
+        'dddddddxsssssssssdx',
       ),
       array(
         'xarray($b)x',
         'zkalrmr(array($b))z',
-        'iiiiiiixsssssssssix'
+        'iiiiiiixsssssssssix',
       ),
       array(
         'abcdefghi',
         'abcdefghi',
-        'sssssssss'
+        'sssssssss',
       ),
       array(
         'abcdefghi',
         'abcdefghijkl',
-        'sssssssssiii'
+        'sssssssssiii',
       ),
       array(
         'abcdefghijkl',
         'abcdefghi',
-        'sssssssssddd'
+        'sssssssssddd',
       ),
       array(
         'xyzabcdefghi',
         'abcdefghi',
-        'dddsssssssss'
+        'dddsssssssss',
       ),
       array(
         'abcdefghi',
         'xyzabcdefghi',
-        'iiisssssssss'
+        'iiisssssssss',
       ),
       array(
         'abcdefg',
         'abxdxfg',
-        'ssxsxss'
+        'ssxsxss',
       ),
       array(
         'private function a($a, $b) {',
         'public function and($b, $c) {',
-        'siixsdddxsssssssssssiissxsssxsss'
+        'siixsdddxsssssssssssiissxsssxsss',
       ),
       array(
 
@@ -121,9 +120,9 @@ public function testGenerateUTF8IntralineDiff() {
     $left = '';
     $right = '';
     $result = array(
-                array(array(0, 0)),
-                array(array(0, 0))
-              );
+      array(array(0, 0)),
+      array(array(0, 0)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
@@ -132,9 +131,9 @@ public function testGenerateUTF8IntralineDiff() {
     $left = '';
     $right = "Grumpy\xE2\x98\x83at";
     $result = array(
-                array(array(0, 0)),
-                array(array(0, 11))
-              );
+      array(array(0, 0)),
+      array(array(0, 11)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
@@ -143,9 +142,9 @@ public function testGenerateUTF8IntralineDiff() {
     $left = "Grumpy\xE2\x98\x83at";
     $right = '';
     $result = array(
-                array(array(0, 11)),
-                array(array(0, 0))
-              );
+      array(array(0, 11)),
+      array(array(0, 0)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
@@ -154,9 +153,9 @@ public function testGenerateUTF8IntralineDiff() {
     $left = "Grumpy\xE2\x98\x83at";
     $right = "Grumpy\xE2\x98\x83at";
     $result = array(
-                array(array(0, 11)),
-                array(array(0, 11))
-              );
+      array(array(0, 11)),
+      array(array(0, 11)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
@@ -165,9 +164,9 @@ public function testGenerateUTF8IntralineDiff() {
     $left = "Grumpy\xE2\x98\x83at";
     $right = 'Smiling Dog';
     $result = array(
-                array(array(1, 11)),
-                array(array(1, 11))
-              );
+      array(array(1, 11)),
+      array(array(1, 11)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
@@ -176,9 +175,9 @@ public function testGenerateUTF8IntralineDiff() {
     $left = 'GrumpyCat';
     $right = "Grumpy\xE2\x98\x83at";
     $result = array(
-                array(array(0, 6), array(1, 1), array(0, 2)),
-                array(array(0, 6), array(1, 3), array(0, 2))
-              );
+      array(array(0, 6), array(1, 1), array(0, 2)),
+      array(array(0, 6), array(1, 3), array(0, 2)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
@@ -187,9 +186,9 @@ public function testGenerateUTF8IntralineDiff() {
     $left = 'GrumpyCat';
     $right = "Grumpy\xE2\x98\x83a\xE2\x98\x83t";
     $result = array(
-                array(array(0, 6), array(1, 2), array(0, 1)),
-                array(array(0, 6), array(1, 7), array(0, 1))
-              );
+      array(array(0, 6), array(1, 2), array(0, 1)),
+      array(array(0, 6), array(1, 7), array(0, 1)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
@@ -198,9 +197,9 @@ public function testGenerateUTF8IntralineDiff() {
     $left = "GrumpyC\xE2\x98\x83t";
     $right = "DrumpyC\xE2\x98\x83t";
     $result = array(
-                array(array(1, 1), array(0, 10)),
-                array(array(1, 1), array(0, 10))
-              );
+      array(array(1, 1), array(0, 10)),
+      array(array(1, 1), array(0, 10)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
@@ -209,9 +208,9 @@ public function testGenerateUTF8IntralineDiff() {
     $left = "GrumpyC\xE2\x98\x83t";
     $right = "GrumpyC\xE2\x98\x83P";
     $result = array(
-                array(array(0, 10), array(1, 1)),
-                array(array(0, 10), array(1, 1))
-              );
+      array(array(0, 10), array(1, 1)),
+      array(array(0, 10), array(1, 1)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
@@ -220,9 +219,9 @@ public function testGenerateUTF8IntralineDiff() {
     $left = "GrumpyC\xE2\x98\x83t";
     $right = "DrumpyC\xE2\x98\x83P";
     $result = array(
-                array(array(1, 1), array(0, 9), array(1, 1)),
-                array(array(1, 1), array(0, 9), array(1, 1))
-              );
+      array(array(1, 1), array(0, 9), array(1, 1)),
+      array(array(1, 1), array(0, 9), array(1, 1)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
@@ -232,11 +231,12 @@ public function testGenerateUTF8IntralineDiff() {
     $left = 'Senor';
     $right = "Sen{$cc}or";
     $result = array(
-                array(array(0, 2), array(1, 1), array(0, 2)),
-                array(array(0, 2), array(1, 3), array(0, 2))
-              );
+      array(array(0, 2), array(1, 1), array(0, 2)),
+      array(array(0, 2), array(1, 3), array(0, 2)),
+    );
     $this->assertEqual(
       $result,
       ArcanistDiffUtils::generateIntralineDiff($left, $right));
   }
+
 }
diff --git a/src/differential/ArcanistDifferentialCommitMessage.php b/src/differential/ArcanistDifferentialCommitMessage.php
@@ -2,8 +2,6 @@
 
 /**
  * Represents a parsed commit message.
- *
- * @group differential
  */
 final class ArcanistDifferentialCommitMessage {
 

diff --git a/src/differential/ArcanistDifferentialCommitMessageParserException.php b/src/differential/ArcanistDifferentialCommitMessageParserException.php
@@ -2,8 +2,6 @@
 
 /**
  * Thrown when a commit message isn't parseable.
- *
- * @group differential
  */
 final class ArcanistDifferentialCommitMessageParserException extends Exception {
 

diff --git a/src/events/constant/ArcanistEventType.php b/src/events/constant/ArcanistEventType.php
@@ -12,4 +12,5 @@ final class ArcanistEventType extends PhutilEventType {
   const TYPE_REVISION_WILLCREATEREVISION = 'revision.willCreateRevision';
 
   const TYPE_LAND_WILLPUSHREVISION  = 'land.willPushRevision';
+
 }
diff --git a/src/exception/ArcanistChooseInvalidRevisionException.php b/src/exception/ArcanistChooseInvalidRevisionException.php
@@ -2,9 +2,5 @@
 
 /**
  * Thrown when the user chooses an invalid revision when prompted by a workflow.
- *
- * @group workflow
  */
-final class ArcanistChooseInvalidRevisionException extends Exception {
-
-}
+final class ArcanistChooseInvalidRevisionException extends Exception {}
diff --git a/src/exception/ArcanistChooseNoRevisionsException.php b/src/exception/ArcanistChooseNoRevisionsException.php
@@ -3,9 +3,5 @@
 /**
  * Thrown when there are no valid revisions to choose from, in a workflow which
  * prompts the user to choose a revision.
- *
- * @group workflow
  */
-final class ArcanistChooseNoRevisionsException extends Exception {
-
-}
+final class ArcanistChooseNoRevisionsException extends Exception {}
diff --git a/src/exception/ArcanistUsageException.php b/src/exception/ArcanistUsageException.php
@@ -4,9 +4,6 @@
  * Thrown when there is a problem with how a user is invoking a command, rather
  * than a technical problem.
  *
- * @group workflow
  * @concrete-extensible
  */
-class ArcanistUsageException extends Exception {
-
-}
+class ArcanistUsageException extends Exception {}
diff --git a/src/exception/usage/ArcanistNoEffectException.php b/src/exception/usage/ArcanistNoEffectException.php
@@ -3,8 +3,5 @@
 /**
  * Thrown when lint or unit tests have no effect, i.e. no paths are affected
  * by any linter or no unit tests provide coverage.
- *
- * @group workflow
  */
-final class ArcanistNoEffectException extends ArcanistUsageException {
-}
+final class ArcanistNoEffectException extends ArcanistUsageException {}
diff --git a/src/exception/usage/ArcanistNoEngineException.php b/src/exception/usage/ArcanistNoEngineException.php
@@ -2,8 +2,5 @@
 
 /**
  * Thrown when no engine is configured for linting or running unit tests.
- *
- * @group workflow
  */
-final class ArcanistNoEngineException extends ArcanistUsageException {
-}
+final class ArcanistNoEngineException extends ArcanistUsageException {}
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,8 +2,6 @@ @@
     /**
      * This class holds everything related to configuration and configuration files.
-     *
-     * @group config
      */
     final class ArcanistConfigurationManager {
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
Expand Up		@@ -12,4 +12,5 @@ final class ArcanistEventType extends PhutilEventType {
		const TYPE_REVISION_WILLCREATEREVISION = 'revision.willCreateRevision';

		const TYPE_LAND_WILLPUSHREVISION = 'land.willPushRevision';

		}