some fixes for bybit order mapping

wawah · Nov 26, 2022 · 86fcb94 · 86fcb94
1 parent 6fb4667
commit 86fcb94
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/dict/order.js b/src/dict/order.js
@@ -140,7 +140,7 @@ module.exports = class Order {
       amount,
       Order.TYPE_LIMIT,
       _.merge(options, {
-        post_only: true
+        post_only: true,
       })
     );
   }
@@ -155,7 +155,7 @@ module.exports = class Order {
       this.TYPE_LIMIT,
       {
         post_only: true,
-        close: true
+        close: true,
       }
     );
   }
@@ -167,7 +167,7 @@ module.exports = class Order {
       undefined,
       amount,
       _.merge(options, {
-        adjust_price: true
+        adjust_price: true,
       })
     );
   }

diff --git a/src/exchange/bybit.js b/src/exchange/bybit.js
@@ -882,12 +882,12 @@ module.exports = class Bybit {
 
         // new format
         if (!price || price === 0.0) {
-          price = parseFloat(order.trigger_price);
+          price = parseFloat(order?.trigger_price);
         }
       }
 
       const options = {};
-      if (order.ext_fields && order.ext_fields.reduce_only === true) {
+      if (order.reduce_only === true || order.ext_fields?.reduce_only === true) {
         options.reduce_only = true;
       }
 

diff --git a/src/exchange/bybit_linear.js b/src/exchange/bybit_linear.js
@@ -473,7 +473,7 @@ module.exports = class BybitLinear {
     delete parameters['order_link_id'];
 
     parameters.reduce_only = order.isReduceOnly();
-    parameters.close_on_trigger = false;
+    parameters.close_on_trigger = order.isReduceOnly();
 
     // limit and stops have different api endpoints
     const isConditionalOrder = this.isConditionalExchangeOrder(order);