Fix potential memory leak in OSSL_IETF_ATTR_SYNTAX_add1_value()

The function may leak memory if it deals with an unknown type. Issue reported by LuMingYinDetect. Fixes openssl#24452 Reviewed-by: Todd Short <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from openssl#24454)
wbl · May 30, 2024 · cfaa79f · cfaa79f
1 parent f7ded92
commit cfaa79f
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/crypto/x509/x_ietfatt.c b/crypto/x509/x_ietfatt.c
@@ -174,6 +174,7 @@ int OSSL_IETF_ATTR_SYNTAX_add1_value(OSSL_IETF_ATTR_SYNTAX *a, int type,
         val->u.string = data;
         break;
     default:
+        OSSL_IETF_ATTR_SYNTAX_VALUE_free(val);
         ERR_raise(ERR_LIB_X509V3, ERR_R_PASSED_INVALID_ARGUMENT);
         return 0;
     }