Skip to content

Commit

Permalink
test(lint): Replace ASCII-only check with ESLint rule
Browse files Browse the repository at this point in the history
This replaces the `ensure-all-text-files-only-ascii` sanity-check
with an ESLint rule to only check identifiers in code against being
printable ASCII, as there are places where UTF-8 in content is required,
which would make the previous check fail.

Change-Type: patch
  • Loading branch information
jhermsmeier committed Apr 2, 2018
1 parent 8886732 commit edf924d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 68 deletions.
3 changes: 3 additions & 0 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ rules:
- min: 2
exceptions:
- "_"
id-match:
- error
- "^[_0-9A-Za-z\\$]+$"
line-comment-position:
- error
- position: above
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,6 @@ sanity-checks:
./scripts/ci/ensure-npm-valid-dependencies.sh
./scripts/ci/ensure-npm-shrinkwrap-versions.sh
./scripts/ci/ensure-all-file-extensions-in-gitattributes.sh
./scripts/ci/ensure-all-text-files-only-ascii.sh

clean:
rm -rf $(BUILD_DIRECTORY)
Expand Down
67 changes: 0 additions & 67 deletions scripts/ci/ensure-all-text-files-only-ascii.sh

This file was deleted.

0 comments on commit edf924d

Please sign in to comment.