Add more test

web3p · Jul 8, 2024 · ab393fd · ab393fd
1 parent b3739a3
commit ab393fd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Crypto/Key.php b/src/Crypto/Key.php
@@ -13,7 +13,6 @@
 use Exception;
 use StarkNet\Constants;
 use StarkNet\Utils;
-use BN\BN;
 
 class Key {
  /**
@@ -25,7 +24,7 @@ class Key {
  * generation on mainnet.
  * 
  * @param BigNumber $keySeed
- * @return BigNumber
+ * @return string
  */
  public static function grindKey ($keySeed)
  {
@@ -38,13 +37,11 @@ public static function grindKey ($keySeed)
  $key = Utils::toBn(\hash('sha256', $msg, false));
  if ($key->compare($maxAllowedValue) < 0) {
  $result = $key->divide($ecOrder);
- // normalize the bignumber
- return new BN($result[1]->toString());
+ return $result[1]->toHex();
  }
  if ($i === 100000) {
  throw new Exception('grindKey is broken: tried 100k vals');
  }
  }
- return $maxAllowedValue;
  }
 }
diff --git a/test/unit/KeyTest.php b/test/unit/KeyTest.php
@@ -20,6 +20,9 @@ public function testGrindKey()
  {
 
  $result = Key::grindKey('86F3E7293141F20A8BAFF320E8EE4ACCB9D4A4BF2B4D295E8CEE784DB46E0519');
- $this->assertEquals('5c8c8683596c732541a59e03007b2d30dbbbb873556fe65b5fb63c16688f941', substr($result->toString(16), 1, 64));
+ $this->assertEquals('05c8c8683596c732541a59e03007b2d30dbbbb873556fe65b5fb63c16688f941', $result);
+
+ $result = Key::grindKey('94F3E7293141F20A8BAFF320E8EE4ACCB9D4A4BF2B4D295E8CEE784DB46E0595');
+ $this->assertEquals('033880b9aba464c1c01c9f8f5b4fc1134698f9b0a8d18505cab6cdd34d93dc02', $result);
  }
 }