Breaking: convert type of all primary keys to uuid4 #1833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change all primary keys to be of type
uuid4
.Best reason to do so is to prevent people from seeing how many applications are sent by looking at their application id. In addition it's practical to not have to convert between string and number all the time. Other than that I see few reasons not to do so (except for the obvious tedious bits in the test when creating users and groups).
To change the types of the IDs I had to reset all the migrations, which requires everyone to reset their databases (and the prod and staging ones, which I'll fix when I'm merging this).
Fixed some other minor stuff while I was at it;
Resolves ABA-165
Resolves #1210, #281
I'm still considering the id change for
LegoUser
andGroup
, so if anyone has any thoughts I'm open for it.