Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: convert type of all primary keys to uuid4 #1833

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

norbye
Copy link
Member

@norbye norbye commented Jan 25, 2025

Change all primary keys to be of type uuid4.

Best reason to do so is to prevent people from seeing how many applications are sent by looking at their application id. In addition it's practical to not have to convert between string and number all the time. Other than that I see few reasons not to do so (except for the obvious tedious bits in the test when creating users and groups).

To change the types of the IDs I had to reset all the migrations, which requires everyone to reset their databases (and the prod and staging ones, which I'll fix when I'm merging this).

Fixed some other minor stuff while I was at it;

  • Links to abakus.no now differentiate between revue groups and committees
  • You can still view an admission outside the deadline if you enter the url directly, but it is not possible to submit an application

Resolves ABA-165
Resolves #1210, #281

I'm still considering the id change for LegoUser and Group, so if anyone has any thoughts I'm open for it.

Copy link

linear bot commented Jan 25, 2025

@norbye norbye added the review-needed Pull requests that need review label Jan 25, 2025
@norbye norbye requested a review from a team January 25, 2025 01:57
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch admissions accessible before offical date
2 participants