Remove shorts from Subscriptions tab #201
Conversation
|
Great work, keen to see this merged - shorts are a real pain point for me |
|
@FuriousBottle Is there any action needed from my side to have this PR merged? |
|
@JaCzekanski sorry for the confusion, I am just an admirer, I don't have any authority here 😅 |
| @@ -6,7 +6,7 @@ | |||
| "packages": { | |||
| "": { | |||
| "name": "youtube-webos", | |||
| "version": "0.3.3", | |||
| "version": "0.3.4", | |||
| @@ -122,6 +122,7 @@ function createOptionsPanel() { | |||
| elmContainer.appendChild(createConfigCheckbox('enableAdBlock')); | |||
| elmContainer.appendChild(createConfigCheckbox('hideLogo')); | |||
| elmContainer.appendChild(createConfigCheckbox('enableSponsorBlock')); | |||
| elmContainer.appendChild(createConfigCheckbox('removeShorts')); | |||
There was a problem hiding this comment.
This should probably either be at the end or before enableSponsorBlock. (Same in config.js.)
| r?.contents?.tvBrowseRenderer?.content?.tvSecondaryNavRenderer?.sections[0] | ||
| ?.tvSecondaryNavSectionRenderer?.tabs[0]?.tabRenderer?.content | ||
| ?.tvSurfaceContentRenderer?.content?.gridRenderer; |
There was a problem hiding this comment.
This is a pretty long/specific path, and I don't know how stable it will be. Is there another way to find the target element?
There was a problem hiding this comment.
I thought about it - doing something like a depth search on the r object to find gridRenderer would get rid of the hardcoded path and should be better in terms of keeping it up to date, but it'll run on all JSONs that are being parsed possibly leading to longer loading times/stutter.
There was a problem hiding this comment.
Would it be possible to string search the unparsed JSON for gridRenderer and replace it with a misspelling? Would YouTube throw when it encounters unexpected keys?
This PR adds filtering of JSON nodes containing
reelWatchEndpointwhich is an indicator that given video is a reel/short.Due to the convoluted format of JSON responses, it might not cover all of the cases.
Reel playback seems broken on TVs and I don't really care about having them, as it's ofter reused content.
Please note that it'll only work on the Subscriptions tab (which is the one I use the most).
However, It should be pretty easy to extend it to other tabs and search results.
Before:
After:
Green settings menu:
