Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update billing tab with usage & portal URL check #1995

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Aug 6, 2024

Resolves #1991

Changes

  • Hides usage table from dashboard if billing is enabled
  • Shows usage table in billing settings
  • Updates usage table column headings
  • Fixes portalUrl task running unnecessarily

Manual testing

  1. Log in as org admin to org with subscription
  2. Click Settings -> Billing. Verify usage history is shown
  3. Click "Manage Billing". Verify billing dashboard loads

Screenshots

Page Image/video
Org Settings - Billing Screenshot 2024-08-06 at 11 23 20 AM

Follow-ups

Per Discord convo, we may want to revisit how we display all the execution minute categories in this table.

@SuaYoo SuaYoo changed the title feat: Update usage table feat: Update billing tab with usage & billing Aug 6, 2024
@SuaYoo SuaYoo changed the title feat: Update billing tab with usage & billing feat: Update billing tab with usage & portal URL check Aug 6, 2024
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think we should also stop capping the usage in the table at the quota but that's out of scope so can address in a separate issue/PR

@SuaYoo SuaYoo merged commit 96e48b0 into main Aug 6, 2024
3 checks passed
@SuaYoo SuaYoo deleted the frontend-billing-usage-history branch August 6, 2024 23:31
ikreymer pushed a commit that referenced this pull request Aug 7, 2024
Following #1995, we want
to keep the usage history table on the dashboard for now for video
demos.

### Changes

- Adds usage history table back to org dashboard
- Makes "No usage history" message more apparent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Change]: Move exec minute history table to the admin billing tab
4 participants