use Guava cache to return ListenableFuture #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no issue here @krvibhav, the issue you describe above is for the new provider caching mechanism we are working on that's not related to this asyncHttpCache. |
|
Can you write test for this scenario ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tam @viettienn
Please review.
Issue: https://github.com/wego/akasha/issues/274
Solution:
Used Guava Cache which ll keep ListenableFuture object based on responseId.
Idea here is if same search happened at the same time, we can use provider requests from both the searches and because we have a guava caching which keeps ListenableFurture object, it ll be non blocking and whenever response is ready for any request it ll be returned to all the requests.
Guava cache suits best here because it handles the concurrency situation properly.