Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGAGE-2641] Fix undefined style error #635

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[ENGAGE-2641] Fix undefined style error #635

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca311c8
adding ? in Modal component
MarcusviniciusLsantos Jan 30, 2025
1ab98cf
adding ? in ModalDialog component
MarcusviniciusLsantos Jan 30, 2025
18052f9
adding ? in TransitionRipple component
MarcusviniciusLsantos Jan 30, 2025
875e431
fix: CI
MarcusviniciusLsantos Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: CI
  • Loading branch information
@MarcusviniciusLsantos
MarcusviniciusLsantos committed Jan 30, 2025
commit 875e4315116775a2f9ecc322ce53335aa5c147f4
2 changes: 1 addition & 1 deletion src/components/ModalDialog/ModalDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export default {
this.$emit('update:modelValue', false);
},
updateBodyOverflow(isHidden) {
document.body?.style.overflow = isHidden ? 'hidden' : '';
document.body.style.overflow = isHidden ? 'hidden' : '';
},
},
};
Expand Down
4 changes: 2 additions & 2 deletions src/components/TransitionRipple/TransitionRipple.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ export default {
const { transitionContainer } = this.$parent.$refs;

if (transitionContainer) {
this.$parent.$refs.transitionContainer?.style.position = 'relative';
this.$parent.$refs.transitionContainer?.style.overflow = 'hidden';
this.$parent.$refs.transitionContainer.style.position = 'relative';
this.$parent.$refs.transitionContainer.style.overflow = 'hidden';
}

const width = transitionContainer.offsetWidth;
Expand Down
Loading