Skip to content

Commit

Permalink
s390/mm: align 64-bit PIE binaries to 4GB
Browse files Browse the repository at this point in the history
The base address (STACK_TOP / 3 * 2) for a 64-bit program is two thirds
into the 4GB segment at 0x2aa00000000. The randomization added on z13
can eat another 1GB of the remaining 1.33GB to the next 4GB boundary.
In the worst case 300MB are left for the executable + bss which may
cross into the next 4GB segment. This is bad for branch prediction,
therefore align the base address to 4GB to give the program more room
before it crosses the 4GB boundary.

Signed-off-by: Martin Schwidefsky <[email protected]>
  • Loading branch information
Martin Schwidefsky committed Feb 19, 2015
1 parent f4dce5c commit 4ba2815
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion arch/s390/mm/mmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,10 @@ unsigned long randomize_et_dyn(void)
{
unsigned long base;

base = (STACK_TOP / 3 * 2) & (~mmap_align_mask << PAGE_SHIFT);
base = STACK_TOP / 3 * 2;
if (!is_32bit_task())
/* Align to 4GB */
base &= ~((1UL << 32) - 1);
return base + mmap_rnd();
}

Expand Down

0 comments on commit 4ba2815

Please sign in to comment.