Skip to content

Commit

Permalink
[media] m88ts2022: Nested loops shouldn't use the same index variable
Browse files Browse the repository at this point in the history
There are a pair of nested loops inside m88ts2022_cmd() that use the same
index variable, but for different things.  Split the variable.

Signed-off-by: David Howells <[email protected]>
Signed-off-by: Antti Palosaari <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
dhowells authored and mchehab committed Apr 3, 2015
1 parent 0fd68f2 commit 67e6590
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/media/tuners/m88ts2022.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
static int m88ts2022_cmd(struct m88ts2022_dev *dev, int op, int sleep, u8 reg,
u8 mask, u8 val, u8 *reg_val)
{
int ret, i;
int ret, i, j;
unsigned int utmp;
struct m88ts2022_reg_val reg_vals[] = {
{0x51, 0x1f - op},
Expand All @@ -35,9 +35,9 @@ static int m88ts2022_cmd(struct m88ts2022_dev *dev, int op, int sleep, u8 reg,
"i=%d op=%02x reg=%02x mask=%02x val=%02x\n",
i, op, reg, mask, val);

for (i = 0; i < ARRAY_SIZE(reg_vals); i++) {
ret = regmap_write(dev->regmap, reg_vals[i].reg,
reg_vals[i].val);
for (j = 0; j < ARRAY_SIZE(reg_vals); j++) {
ret = regmap_write(dev->regmap, reg_vals[j].reg,
reg_vals[j].val);
if (ret)
goto err;
}
Expand Down

0 comments on commit 67e6590

Please sign in to comment.