Skip to content

Commit

Permalink
mm: update stale lock ordering comment for memory-failure.c
Browse files Browse the repository at this point in the history
When i_mmap_lock changed to a mutex the locking order in memory failure
was changed to take the sleeping lock first.  But the big fat mm lock
ordering comment (BFMLO) wasn't updated.  Do this here.

Pointed out by Andrew.

Signed-off-by: Andi Kleen <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Andi Kleen authored and torvalds committed Mar 22, 2012
1 parent 47a1333 commit 9a3c531
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions mm/filemap.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,8 @@
* ->inode->i_lock (zap_pte_range->set_page_dirty)
* ->private_lock (zap_pte_range->__set_page_dirty_buffers)
*
* (code doesn't rely on that order, so you could switch it around)
* ->tasklist_lock (memory_failure, collect_procs_ao)
* ->i_mmap_mutex
* ->i_mmap_mutex
* ->tasklist_lock (memory_failure, collect_procs_ao)
*/

/*
Expand Down

0 comments on commit 9a3c531

Please sign in to comment.