A little bit of code cleanup

wesleyknuts · Nov 13, 2019 · 6a7efbb · 6a7efbb
1 parent e006d3f
commit 6a7efbb
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 28 deletions.
diff --git a/fa2cs/CodeWriter.cs b/fa2cs/CodeWriter.cs
@@ -8,14 +8,14 @@ public class CodeWriter
     {
         const string indent = "    ";
 
-        public string Write(List<FontAwesomeIcon> icons)
+        public string Write(IEnumerable<FontAwesomeIcon> icons)
         {
             Console.Write("Generating C# code...");
 
             var classTemplate = ResourcesHelper.ReadResourceContent("ClassTemplate.txt");
             var propertyTemplate = ResourcesHelper.ReadResourceContent("PropertyTemplate.txt");
 
-            List<string> properties = new List<string>();
+            var properties = new List<string>();
 
             foreach (var icon in icons)
             {

diff --git a/fa2cs/FontAwesomeDownloader.cs b/fa2cs/FontAwesomeDownloader.cs
@@ -9,7 +9,7 @@ namespace fa2cs
 {
     public class FontAwesomeDownloader
     {
-        public async Task<List<FontAwesomeIcon>> DownloadIconCodes(string endpoint)
+        public async Task<IReadOnlyList<FontAwesomeIcon>> DownloadIconCodes(string endpoint)
         {
             using (var client = new HttpClient())
             {

diff --git a/fa2cs/Program.cs b/fa2cs/Program.cs
@@ -11,10 +11,6 @@ class MainClass
     {
         public const string Endpoint = "https://fontawesome.com/cheatsheet";
 
-        public const string FontAwesomeIconsAssemblyFileName = "FontAwesome.IconCodes.dll";
-
-        public const string FontAwesomeIconsAssemblyDocsFileName = "FontAwesome.IconCodes.xml";
-
         public static async Task Main(string[] args)
         {
             var exportPath = AssemblyHelper.EntryAssemblyDirectory;
@@ -39,7 +35,6 @@ public static async Task Main(string[] args)
 
             var code = codeWriter.Write(icons);
 
-            File.WriteAllText(Path.Combine(outputPath, "readme.txt"), ResourcesHelper.ReadResourceContent("readme.txt"));
             File.WriteAllText(Path.Combine(exportPath, "FontAwesomeIcons.cs"), code);
 
             OpenFileHelper.OpenAndSelect(exportPath);

diff --git a/fa2cs/Resources/readme.txt b/fa2cs/Resources/readme.txt
diff --git a/fa2cs/fa2cs.csproj b/fa2cs/fa2cs.csproj
@@ -202,12 +202,6 @@
     <EmbeddedResource Include="Resources\PropertyTemplate.txt">
       <LogicalName>PropertyTemplate.txt</LogicalName>
     </EmbeddedResource>
-    <EmbeddedResource Include="Resources\AssemblyInfoTemplate.txt">
-      <LogicalName>AssemblyInfoTemplate.txt</LogicalName>
-    </EmbeddedResource>
-    <EmbeddedResource Include="Resources\readme.txt">
-      <LogicalName>readme.txt</LogicalName>
-    </EmbeddedResource>
   </ItemGroup>
   <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
   <Import Project="..\packages\SQLitePCLRaw.lib.e_sqlite3.linux.1.1.2\build\SQLitePCLRaw.lib.e_sqlite3.linux.targets" Condition="Exists('..\packages\SQLitePCLRaw.lib.e_sqlite3.linux.1.1.2\build\SQLitePCLRaw.lib.e_sqlite3.linux.targets')" />