Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add celo fee.estimateFeePerGas #2041

Merged
merged 5 commits into from
Mar 30, 2024
Merged

Add celo fee.estimateFeePerGas #2041

merged 5 commits into from
Mar 30, 2024

Conversation

shazarre
Copy link
Contributor

@shazarre shazarre commented Mar 29, 2024

Overview

This PR introduces custom Celo fee estimation for cases when feeCurrency is used to send a transaction.

Other changes

It also introduces a fallback behaviour of the custom estimation logic.

Tested

  • Introduced new unit tests and adapted existing ones.
  • Tested for different fee currencies (as well as without it) on alfajores

PR-Codex overview

This PR adds a custom Celo fees estimation function for transactions with feeCurrency. It also refactors ChainEstimateFeesPerGasFn and updates related tests.

Detailed summary

  • Added custom fees estimation function for feeCurrency transactions in Celo
  • Refactored ChainEstimateFeesPerGasFn in chain.ts
  • Updated tests for estimateFeesPerGas
  • Added new functions for estimating fees in fees.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: a297a50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 29, 2024

@aaronmgdr is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom jxom force-pushed the main branch 2 times, most recently from 72fd0a8 to ea6e0f5 Compare March 29, 2024 20:54
@jxom jxom merged commit 29eea54 into wevm:main Mar 30, 2024
2 of 3 checks passed
@tmm tmm mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants