-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eip-1271 #320
feat: eip-1271 #320
Conversation
adding a JSDoc comment to the old util.verifyMessage and util.verifyTypedData function
🦋 Changeset detectedLatest commit: 1555156 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@janek26 is attempting to deploy a commit to the wagmi Team on Vercel. A member of the Team first needs to authorize it. |
param and return type are the same between the utils method and the public action
36db3f0
to
7fc8e0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really solid! Nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good so far! Haven't looked at this too much in-depth yet, and will properly review this after the concerns I raised above have been addressed!
TldrThis PR adds two new methods, Detailed summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really excited about this pr thank you so much for doing this!
Hey all! Just letting you know I’ll have a busy weekend and get back to you all after eastern! Enjoy everyone 🐰🥚 |
c67a3b1
to
19c1e4e
Compare
b54ae19
to
841c885
Compare
validates ERC6492, ERC1271 and EOAs in this order
updated the PR It's now using a deployless universal verifier contract, so it's sending 1 imo this is ready for reviews/merge 🙏 |
Codecov Report
@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 99.92% 95.27% -4.65%
==========================================
Files 254 254
Lines 23688 23635 -53
Branches 1967 1669 -298
==========================================
- Hits 23670 22519 -1151
- Misses 18 1111 +1093
- Partials 0 5 +5
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d6736c3
to
82414dc
Compare
Implements 2 new public actions:
which have the same interface as their
utils
counterparts, but also support EIP-1271Added some hints in the documentation (website and JSDoc) for developers which method they want to choose and why.
🤖 Generated by Copilot at 0f87d3d
This pull request adds two new public actions,
verifyMessage
andverifyTypedData
, to the public client and the public actions module. It also adds the documentation for these actions in thesite/docs
folder and updates the sidebar accordingly. Additionally, it updates the tests and the constants for the public actions, and imports the smart account contract abi for testing ERC-1271 verification.PR-Codex overview
This PR adds support for Contract Wallet signature verification (EIP-6492) via
publicClient.verifyMessage
&publicClient.verifyTypedData
.Detailed summary
publicClient.verifyMessage
&publicClient.verifyTypedData
smartAccountAbi
anduniversalSignatureValidatorAbi
toabis.ts
verifyMessage
andverifyTypedData
functions toverifyMessage.ts
andverifyTypedData.ts
, respectivelycreatePublicClient.test.ts
andpublic.ts
to includeverifyMessage
andverifyTypedData
inPublicActions
typeverifyMessage
andverifyTypedData
inverifyMessage.test.ts
andverifyTypedData.test.ts
, respectively.