Skip to content

Commit

Permalink
[FIX] lunch,web: display correctly list's cell with text overflow
Browse files Browse the repository at this point in the history
Installing the 'lunch' module add css rules to the generic list view
styling, modifying the styling of all the list views by the simple fact
of being installed.

The goal of those rules is that in list view a table cell with the
o_text_overflow class should still be displayed as a table-cell (and not
a block/inline-block).

Without the lunch module a list view's cell with the o_text_overflow
class is narrower and break the alignment between this column and the
headers.

This commit moves the necessary rule (display property) to the web
module and apply them globally.

Remark: module's css rules shouldn't override globally the one from
'web'.

Original commit: odoo@855c6da

closes odoo#31506
  • Loading branch information
pparidans committed Feb 28, 2019
1 parent abb95e4 commit c0f8690
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
8 changes: 0 additions & 8 deletions addons/lunch/static/src/scss/lunch_kanban.scss
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
.o_list_view {
.o_data_row {
.o_text_overflow {
@include o-text-overflow(table-cell);
}
}
}

.o_lunch_kanban {
display: flex;
flex-direction: column; // display lunch widget above kanban renderer
Expand Down
1 change: 1 addition & 0 deletions addons/web/static/src/scss/list_view.scss
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@
white-space: pre-wrap;
}

.o_data_cell.o_text_overflow,
.o_data_cell.o_invisible_modifier {
// Override display: none to keep table cells aligned. Note: cannot use
// 'initial' as it will force them to 'inline', not 'table-cell'.
Expand Down

0 comments on commit c0f8690

Please sign in to comment.