poll test passes

README.md

@@ -105,8 +105,8 @@ Have both is too confusing.
 
 # current progress
 
-Hello world tests are passing on macos, linux, and cross compiling on linux for
-windows using mingw. The library is almost feature complete.
+All tests are passing on macos, linux. Most tests pass on cross compiling on
+linux for windows using mingw. The library is almost feature complete.
 
 must to be implemented
 

src/cpp/subprocess/ProcessBuilder.cpp

@@ -305,7 +305,7 @@ namespace subprocess {
         DWORD exit_code;
         GetExitCodeProcess(process_info.hProcess, &exit_code);
         returncode = exit_code;
-        return returncode;
+        return true;
     }
 
     int Popen::wait(double timeout) {

test/basic_test.cpp

@@ -229,6 +229,24 @@ class BasicSuite : public CxxTest::TestSuite {
     }
 
     void testPoll() {
+        subprocess::EnvGuard guard;
+        std::string path = subprocess::cenv["PATH"];
+        path = TEST_BINARY_DIR + subprocess::kPathDelimiter + path;
+        subprocess::cenv["PATH"] = path;
+
+        auto popen = RunBuilder({"sleep", "3"}).popen();
+        subprocess::StopWatch timer;
+
+        int count = 0;
+        while(!popen.poll())
+            ++count;
+        TS_TRACE("poll did " + std::to_string(count) + " iterations");
+        TS_ASSERT(count > 100);
+
+        popen.close();
+
+        double timeout = timer.seconds();
+        TS_ASSERT_DELTA(timeout, 3, 0.1);
 
     }