Meta: move general guidelines to the whatwg/meta repo #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
commented
Jan 25, 2017
| The HTML Standard is quite complex and people notice minor and larger issues with it all the time. We'd love your help fixing these. Pull requests for typographical and grammar errors are also most welcome. | ||
|
|
||
| We label [good first bugs](https://github.com/whatwg/html/labels/good%20first%20bug) that you could help us fix, to get a taste for how to submit pull requests, how the build process works, and so on. | ||
|
|
||
| We'd be happy to mentor you through this process. If you're interested and need help getting started, leave a comment on the issue or bug, or ask around [on IRC](https://wiki.whatwg.org/wiki/IRC). The [WHATWG FAQ](https://wiki.whatwg.org/wiki/FAQ) may also be helpful. | ||
|
|
||
| ### Pull requests | ||
| ## Pull requests | ||
|
|
||
| In short, change `source` and submit your patch, with a [good commit message](https://github.com/erlang/otp/wiki/Writing-good-commit-messages). |
There was a problem hiding this comment.
I made no attempt to generalize and move this. Should I?
foolip
added a commit
to whatwg/meta
that referenced
this pull request
Jan 26, 2017
These are extracted from HTML, with a corresponding PR: whatwg/html#2295
zcorpan
reviewed
Jan 26, 2017
| This checks out the PR's commits, rebases them on `master`, then fast-forwards `master` to include them. | ||
|
|
||
| The `git push --force` line here ensures that the original branch gets updated to sit on top of `master` as well. This ensures GitHub can automatically figure out that the commits were merged, and thus automatically close the pull request with a nice purple "merged" status. So at this point you can do a `git push origin master` to push the changes, and GitHub will close the PR and mark it as merged. | ||
| These are the guidelines for the team maintaining the HTML Standard. First see the [WHATWG maintainer guidelines](meta/blob/master/CONTRIBUTING.md). |
There was a problem hiding this comment.
Oops, fixed, and I'll now squash into a single commit for final review.
foolip
force-pushed
the
general-guidelines
branch
from
fa8dd33 to
03145e0
Compare
foolip
changed the title
zcorpan
approved these changes
Jan 26, 2017
foolip
added a commit
to whatwg/meta
that referenced
this pull request
Jan 27, 2017
These are extracted from HTML, with a corresponding PR: whatwg/html#2295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/meta#13