refactor!: streamline and improve applayout api #657
+80
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
iisakkirotko
force-pushed
the
05-21-refactor_streamline_and_improve_applayout_api
branch
from
bd314ec to
569256e
Compare
iisakkirotko
force-pushed
the
05-21-fix_show_appbar_when_tabs_are_the_only_children
branch
from
1f72013 to
51b28c5
Compare
iisakkirotko
force-pushed
the
05-21-refactor_streamline_and_improve_applayout_api
branch
from
569256e to
315d628
Compare
iisakkirotko
force-pushed
the
05-21-fix_show_appbar_when_tabs_are_the_only_children
branch
from
51b28c5 to
c34291a
Compare
iisakkirotko
force-pushed
the
05-21-refactor_streamline_and_improve_applayout_api
branch
from
315d628 to
e0483ce
Compare
iisakkirotko
force-pushed
the
05-21-fix_show_appbar_when_tabs_are_the_only_children
branch
from
c34291a to
4ce4cf2
Compare
iisakkirotko
force-pushed
the
05-21-refactor_streamline_and_improve_applayout_api
branch
2 times, most recently
from
289e509 to
569a43c
Compare
iisakkirotko
force-pushed
the
05-21-fix_show_appbar_when_tabs_are_the_only_children
branch
from
504c870 to
5b2fff1
Compare
iisakkirotko
force-pushed
the
05-21-refactor_streamline_and_improve_applayout_api
branch
from
569a43c to
cb5426e
Compare
BREAKING CHANGE: an error is now raised if a reactive variable (not its value) is used in boolean comparisons BREAKIGN CHANGE: mutation detection is now enabled by default
iisakkirotko
force-pushed
the
05-21-refactor_streamline_and_improve_applayout_api
branch
from
cb5426e to
565b543
Compare
iisakkirotko
changed the base branch from
05-21-fix_show_appbar_when_tabs_are_the_only_children
to
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
This was referenced Dec 23, 2024
Draft
iisakkirotko
force-pushed
the
05-21-refactor_streamline_and_improve_applayout_api
branch
from
565b543 to
caff565
Compare
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
3a90256 to
3cdb9d4
Compare
4 tasks
iisakkirotko
force-pushed
the
12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
branch
from
3cdb9d4 to
03b2dcd
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #584.
Includes four breaking changes:
AppBarfrom"primary"to the Vuetify default (light/dark grey depending on theme)navigationargument, where previously it would hide the entireAppBarit now correctly only hides the tab navigation (if present)show_app_bar(which is now also available as an argument) to where it no longer requires thetitle-argument to be set forshow_app_barto be true.AppBarchild ofAppLayoutinto a sidebar element.