Skip to content

Commit

Permalink
Fix some code bugs (krahets#1021)
Browse files Browse the repository at this point in the history
* fix(counting_sort.c): Fix access out-of-bounds issue

* fix(hash_map_open_addressing.c): Fix coding errors

* fix(binary_search_tree.c): Fix unreleased memory

* Update indentataion
  • Loading branch information
Gonglja authored Jan 2, 2024
1 parent ef40418 commit 3a559f1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions codes/c/chapter_hashing/hash_map_open_addressing.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,15 @@ void put(HashMapOpenAddressing *hashMap, int key, char *val) {
// 若找到键值对,则覆盖 val 并返回
if (hashMap->buckets[index] != NULL && hashMap->buckets[index] != hashMap->TOMBSTONE) {
free(hashMap->buckets[index]->val);
hashMap->buckets[index]->val = (char *)malloc(sizeof(strlen(val + 1)));
hashMap->buckets[index]->val = (char *)malloc(sizeof(strlen(val) + 1));
strcpy(hashMap->buckets[index]->val, val);
hashMap->buckets[index]->val[strlen(val)] = '\0';
return;
}
// 若键值对不存在,则添加该键值对
Pair *pair = (Pair *)malloc(sizeof(Pair));
pair->key = key;
pair->val = (char *)malloc(sizeof(strlen(val + 1)));
pair->val = (char *)malloc(sizeof(strlen(val) + 1));
strcpy(pair->val, val);
pair->val[strlen(val)] = '\0';

Expand Down
2 changes: 1 addition & 1 deletion codes/c/chapter_sorting/counting_sort.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ void countingSortNaive(int nums[], int size) {
}
// 2. 统计各数字的出现次数
// counter[num] 代表 num 的出现次数
int *counter = calloc(m, sizeof(int));
int *counter = calloc(m + 1, sizeof(int));
for (int i = 0; i < size; i++) {
counter[nums[i]]++;
}
Expand Down
2 changes: 2 additions & 0 deletions codes/c/chapter_tree/binary_search_tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ void removeItem(BinarySearchTree *bst, int num) {
} else {
pre->right = child;
}
// 释放内存
free(cur);
} else {
/* 子节点数量 = 2 */
// 获取中序遍历中 cur 的下一个节点
Expand Down

0 comments on commit 3a559f1

Please sign in to comment.