Set minimum railties version to match used methods #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I tried to use committee-rails 0.6.1 with a Rails 5.0 application (in a CI pipeline) and it failed with an error message that lead me to writing this PR.
When I tried to figure out what the error message means, I checked the diff between 0.5.0 (which worked a month ago) and 0.6.1 and found that you're using a
delegate_missing_to
method inlib/committee/rails/request_object.rb
, which was introduced in Rails 5.1.I quickly checked out the repo, tried to run the test suite with Rails 5.0 and got this (similar what I'm seeing in the original CI)
As Rails 5.0 is not maintained anymore, I think the best is to drop the support here.