Skip to content

Commit

Permalink
Clarify links to code review related pages.
Browse files Browse the repository at this point in the history
Change-Id: Ia91fe1c0ac87d72a0d1d981f455ee6f8afd74571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5975342
Reviewed-by: Chase Phillips <[email protected]>
Commit-Queue: Vincent Scheib <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1375647}
  • Loading branch information
scheib authored and Chromium LUCI CQ committed Oct 30, 2024
1 parent fb39a28 commit 66fc2d4
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
11 changes: 8 additions & 3 deletions docs/code_reviews.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@
Code reviews are a central part of developing high-quality code for Chromium.
All change lists (CLs) must be reviewed.

The general patch, upload, and land process is covered in more detail in the
[contributing code](contributing.md) page. To learn about the code review changes
and OWNERS policy changes launched on March 24, 2021, see
This page documents policy rules regarding code changes.

See also:
- The general patch, upload, and land process in [contributing code](contributing.md#code-review)
- [Code of conduct](../CODE_OF_CONDUCT.md)
- [Respectful Changes](cl_respect.md)
- [Respectful Code Reviews](cr_respect.md)
- The code review changes and OWNERS policy changes launched on March 24, 2021, see
[Mandatory Code Review and Native OWNERS](code_review_owners.md).

# Code review policies
Expand Down
12 changes: 8 additions & 4 deletions docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,14 @@ feature A change is the parent of the feature B change. If A
introduces a new file which B changes, the review for B will only show
the diff from A.

## Code review

Code reviews are covered in more detail on the [code review
policies][code-reviews] page.
## Code review {#code-review}

This section describes the mechanics and process of code reviews. See also:
- [Code review policies](code_reviews.md) page for committer, OWNERS, and other
rules
- [Code of conduct](../CODE_OF_CONDUCT.md)
- [Respectful Changes](cl_respect.md)
- [Respectful Code Reviews](cr_respect.md)

### Finding a reviewer

Expand Down

0 comments on commit 66fc2d4

Please sign in to comment.