Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TeamRepository): Prevent removal of MLS from supported protocols if it was previously supported #18797

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Feb 25, 2025

https://wearezeta.atlassian.net/browse/WPB-16255

Description

Prevent removal of MLS from supported protocols if it was previously supported

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@typfel
Copy link
Member

typfel commented Feb 26, 2025

I think there's a confusion between the teamSupportedProtocols (feature config) and the userSupportedProtocols (self fuser). Here you seem to prevent removing MLS from the teamSupportedProtocols but we should actually prevent removing MLS from the userSupportedProtocols which are updated by calling PUT /self/supported-protocols.

@thisisamir98
Copy link
Contributor

@typfel addressed your concern in here: c1c6030

Copy link

@thisisamir98 thisisamir98 merged commit e776942 into dev Feb 28, 2025
14 of 15 checks passed
@thisisamir98 thisisamir98 deleted the feat/WPB-16255-prevent-removal-of-mls-from-supported-protocols branch February 28, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants