feat(cells): repository logic for the file dropzone #18800
Conversation
olafsulich
changed the title
src/script/components/Conversation/useFilesUploadState/useFilesUploadState.ts
Outdated
Show resolved
Hide resolved
| top: '50%', | ||
| left: '50%', | ||
| transform: 'translate(-50%, -50%)', | ||
| width: '32px', | ||
| height: '32px', | ||
| backgroundColor: 'var(--white)', | ||
| borderRadius: '50%', | ||
| display: 'flex', | ||
| alignItems: 'center', | ||
| justifyContent: 'center', |
There was a problem hiding this comment.
Instead of this, You can use inset: 0, display: 'grid', (placeContent | placeSelf | placeItems): 'center', instead of transform, top, left, and flex with alignItems and justifyContent ?
There was a problem hiding this comment.
I can replace flexbox centering with grid and placeItems - but IMO there's no difference, just one property less
Same with the transform part, I can, and it's just property less, but I think it's not important
| top: '50%', | ||
| left: '50%', | ||
| transform: 'translate(-50%, -50%)', | ||
| width: '32px', | ||
| height: '32px', | ||
| backgroundColor: 'var(--white)', | ||
| borderRadius: '50%', | ||
| display: 'flex', | ||
| alignItems: 'center', | ||
| justifyContent: 'center', |
There was a problem hiding this comment.
Maybe You can create common styles for this? Because I see You have in multiple places same styles :)
There was a problem hiding this comment.
I was thinking about it, but as long as it's not that much code, and it's only in two places, I would stay with it for now
|
Description
What's changed:
Demo
Upload success:
successful_upload.mov
Upload failed:
upload_error_plus_retries.mov
Checklist