Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pagination active dot visibility [WPB-16183] #18814

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

waseemansar
Copy link
Contributor

@waseemansar waseemansar commented Feb 27, 2025

BugWPB-16183 [Web] Popped out calling view when resized small, clicking on bubble to change page should not do anything

Description

Fixes the issue where use can navigate through pagination dot buttons but active dot was not rendering properly and user cannot see the exact active page.

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.61%. Comparing base (b48f04b) to head (b938d7f).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18814      +/-   ##
==========================================
+ Coverage   45.58%   45.61%   +0.02%     
==========================================
  Files        1027     1027              
  Lines       28255    28258       +3     
  Branches     6346     6346              
==========================================
+ Hits        12880    12889       +9     
+ Misses      13770    13768       -2     
+ Partials     1605     1601       -4     

@waseemansar waseemansar merged commit 2ae0336 into dev Feb 28, 2025
14 of 15 checks passed
@waseemansar waseemansar deleted the fix/pagination-active-dot-visibility branch February 28, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants