Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show group settings to group members in read-only mode [WPB-15796] #18833

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

waseemansar
Copy link
Contributor

@waseemansar waseemansar commented Mar 6, 2025

TaskWPB-15796 [Web] Make group options settings visible for regular users (not admins)

Description

This change makes group settings visible to all group members while maintaining admin-only edit permissions. Non-admin members can now view settings but cannot modify them.

  • Modified ConversationDetailsOptions to show settings to all members
  • Added disabled state to settings options for non-admin members
  • Updated UI to indicate read-only state with visual cues
  • Added proper cursor handling for disabled elements

Screenshots/Screencast (for UI changes)

Before

issue-WPB-15796

After

fix-WPB-15796
fix2-WPB-15796.mov

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

sonarqubecloud bot commented Mar 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants