-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement author profiles #1366
Conversation
✅ Deploy Preview for astro-www-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool work @TheOtterlord! Left some notes based on our discussions and also a couple of design thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great @TheOtterlord! And cool to see those articles properly labelled in the accessibility tree:
Spotted a few tiny details but otherwise looking great!
Co-authored-by: Chris Swithinbank <[email protected]>
Thanks for the updates @TheOtterlord! Turns out I was wrong about the 404s I guess. It works locally but in the preview deploy I just get a blank page. Guess we should figure out how to do that properly. One other 404 thing: looks like we need to handle pagination 404s. Currently I get content even if I add an out of range page number e.g. https://deploy-preview-1366--astro-www-2.netlify.app/themes/author/823/ (Edit: ah, I see now it's actually a redirect to page 1. Better than nothing if we can't figure out properly serving a 404) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, sorry for the churn but recommending we switch back to Astro.redirect()
after all 😅
After that, should be good to go I think!
screenshots
Browser Test Checklist
I have tested this PR on at least three of the following browsers: