fix: make reference()
a sync transform
#12781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently the transform used in
reference()
is async. This was a change with content collections to allow the store to be loaded. However this caused an issue during JSON schema generation when combined withdefault()
. See withastro/docs#10362 where this reported as part of a docs PR.This PR updates the transform to instead preload the store and then make the transform itself sync.
Testing
Updated fixture to use the
reference().default()
syntax that previously broke.Docs