Fix error handling bug in mongodb processor

This regression was introduced in 64eb72.
withnocode · Nov 14, 2022 · bd4ba39 · bd4ba39
1 parent f36daad
commit bd4ba39
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,10 @@ All notable changes to this project will be documented in this file.
 - Field `client_session_keep_alive` added to the `snowflake_put` output.
 - Bloblang now supports metadata access via `@foo` syntax, which also supports arbitrary values.
 
+### Fixed
+
+- Fixed a regression bug in the `mongodb` processor where message errors were not set any more. This issue was introduced in v4.7.0 (64eb72).
+
 ## 4.10.0 - 2022-10-26
 
 ### Added

diff --git a/internal/impl/mongodb/processor.go b/internal/impl/mongodb/processor.go
@@ -228,8 +228,13 @@ func NewProcessor(conf processor.Config, mgr bundle.NewManagement) (processor.V2
 // resulting messages or a response to be sent back to the message source.
 func (m *Processor) ProcessBatch(ctx context.Context, spans []*tracing.Span, batch message.Batch) ([]message.Batch, error) {
 	writeModelsMap := map[*mongo.Collection][]mongo.WriteModel{}
-	_ = batch.Iter(func(i int, p *message.Part) error {
-		var err error
+	_ = batch.Iter(func(i int, p *message.Part) (err error) {
+		defer func() {
+			if err != nil {
+				p.ErrorSet(err)
+			}
+		}()
+
 		var filterVal, documentVal *message.Part
 		var upsertVal, filterValWanted, documentValWanted bool