Skip to content

Commit

Permalink
remove todo to handle bug in old version of docker compose; not an is…
Browse files Browse the repository at this point in the history
…sue in new versions (airbytehq#8122)
  • Loading branch information
cgardens authored Nov 19, 2021
1 parent d67afa7 commit 005e4f2
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions tools/bin/acceptance_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ assert_root

echo "Starting app..."

# todo (cgardens) - docker-compose 1.27.3 contained a bug that causes a failure if the volume path
# does not exist when the volume is created. It was fixed in 1.27.4. Github actions virtual envs,
# however, new ubuntu release upgraded to 1.27.3 on 09/24/20. Once github actions virtual envs
# upgrades to 1.27.4, we can stop manually making the directory.
mkdir -p /tmp/airbyte_local

# Detach so we can run subsequent commands
VERSION=dev TRACKING_STRATEGY=logging docker-compose up -d
trap "echo 'docker-compose logs:' && docker-compose logs -t --tail 1000 && docker-compose down -v" EXIT
Expand Down

0 comments on commit 005e4f2

Please sign in to comment.