Magicked files in modules need complex references. #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmen
previously approved these changes
Dec 27, 2024
barnson
force-pushed
the
bob/MagicFilesinRootModules8860
branch
from
ca9f6ae to
79096b2
Compare
robmen
previously approved these changes
Dec 27, 2024
Magic files (naked `File`s and `Files`) that are direct children of a `Module` need complex references from the generated component to that module, to ensure that they're wired up correctly as module components. Fixes wixtoolset/issues#8860
barnson
force-pushed
the
bob/MagicFilesinRootModules8860
branch
from
79096b2 to
faf62a3
Compare
robmen
approved these changes
Dec 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magic files (naked
Files andFiles) that are direct children of aModuleneed complex references from the generated component to that module, to ensure that they're wired up correctly as module components.Fixes wixtoolset/issues#8860