Tidy up spotbugs exclude filter

wodencafe · Aug 8, 2020 · c8d04ca · c8d04ca
1 parent 1a01c87
commit c8d04ca
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 97 deletions.
diff --git a/findbugs-exclude-filter.xml b/findbugs-exclude-filter.xml
diff --git a/pom.xml b/pom.xml
@@ -403,7 +403,7 @@ file comparators, endian transformation classes, and much more.
          </dependency>
         </dependencies>
         <configuration>
-          <excludeFilterFile>${basedir}/sb-excludes.xml</excludeFilterFile>
+          <excludeFilterFile>${basedir}/spotbugs-exclude-filter.xml</excludeFilterFile>
         </configuration>
       </plugin>
     </plugins>
@@ -425,7 +425,7 @@ file comparators, endian transformation classes, and much more.
         <artifactId>spotbugs-maven-plugin</artifactId>
         <version>${spotbugs.plugin.version}</version>
         <configuration>
-          <excludeFilterFile>${basedir}/sb-excludes.xml</excludeFilterFile>
+          <excludeFilterFile>${basedir}/spotbugs-exclude-filter.xml</excludeFilterFile>
         </configuration>
       </plugin>
     </plugins>

diff --git a/sb-excludes.xml → spotbugs-exclude-filter.xml b/sb-excludes.xml → spotbugs-exclude-filter.xml
@@ -17,5 +17,24 @@
 -->
 <FindBugsFilter>
 
+  <!--  See discussion on https://issues.apache.org/jira/browse/IO-216 -->
+  <Match>
+    <Class name="org.apache.commons.io.output.LockableFileWriter" />
+    <Method name="close" params="" returns="void" />
+    <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
+  </Match>
+
+  <!-- The constructors intentionally do not copy the input byte array -->
+  <Match>
+    <Class name="org.apache.commons.io.input.UnsynchronizedByteArrayInputStream" />
+    <Method name="&lt;init&gt;" />
+    <Bug pattern="EI_EXPOSE_REP2" />
+  </Match>
+
+  <!-- The encoding is irrelevant as output is binned -->
+  <Match>
+    <Class name="org.apache.commons.io.output.NullPrintStream" />
+    <Bug pattern="DM_DEFAULT_ENCODING" />
+  </Match>
 
 </FindBugsFilter>