Modified function get_id to iterate over dictionary only once. (micro…

…soft#1140)
wolfdw · Jun 3, 2019 · 3745583 · 3745583
1 parent 5c31530
commit 3745583
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/examples/trials/ga_squad/trial.py b/examples/trials/ga_squad/trial.py
@@ -79,9 +79,7 @@ def get_id(word_dict, word):
     '''
     Return word id.
     '''
-    if word in word_dict.keys():
-        return word_dict[word]
-    return word_dict['<unk>']
+    return word_dict.get(word, word_dict['<unk>'])
 
 
 def load_embedding(path):

diff --git a/examples/trials/weight_sharing/ga_squad/data.py b/examples/trials/weight_sharing/ga_squad/data.py
@@ -241,9 +241,7 @@ def get_id(word_dict, word):
     '''
     Given word, return word id.
     '''
-    if word in word_dict.keys():
-        return word_dict[word]
-    return word_dict['<unk>']
+    return word_dict.get(word, word_dict['<unk>'])
 
 
 def get_buckets(min_length, max_length, bucket_count):