Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tshark package #38108

Merged
merged 5 commits into from
Dec 23, 2024
Merged

add tshark package #38108

merged 5 commits into from
Dec 23, 2024

Conversation

jamonation
Copy link
Member

@jamonation jamonation commented Dec 21, 2024

Pre-review Checklist

For new package PRs only

  • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)

Signed-off-by: Jamon <[email protected]>
@octo-sts octo-sts bot added the bincapz/blocking Bincapz (aka malcontent) scan results detected CRITICALs on the packages. label Dec 21, 2024
tshark.yaml Outdated Show resolved Hide resolved
Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at package contents, I think we can do a split/doc and split/dev as well. 💭

@jamonation
Copy link
Member Author

looking at package contents, I think we can do a split/doc and split/dev as well. 💭

Ah I tried split/manpages and got null 🤦

split/dev isn't helpful here - it ends up grabbing the .so symlinks. Since tshark doesn't install any development headers, that subpackage shouldn't be needed.

kranurag7
kranurag7 previously approved these changes Dec 22, 2024
@jamonation jamonation merged commit 7d2324b into wolfi-dev:main Dec 23, 2024
9 of 10 checks passed
@jamonation jamonation deleted the tshark branch December 23, 2024 00:54
@stevebeattie stevebeattie added malcontent/reviewed The malcontent findings in this PR have been manually reviewed by security. bincapz/blocking Bincapz (aka malcontent) scan results detected CRITICALs on the packages. and removed bincapz/blocking Bincapz (aka malcontent) scan results detected CRITICALs on the packages. labels Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bincapz/blocking Bincapz (aka malcontent) scan results detected CRITICALs on the packages. malcontent/reviewed The malcontent findings in this PR have been manually reviewed by security.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants