Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cilium-envoy-1.16/1.16.5-r0: cve remediation #38294

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 24, 2024

Signed-off-by: Ajay Kemparaj <[email protected]>
Copy link
Contributor Author

octo-sts bot commented Dec 24, 2024

Gen AI suggestions to solve the build error:

• Detected Error:

go: errors parsing go.mod:
/home/build/go.mod:3: invalid go version '1.23.4': must match format 1.23

• Error Category: Version/Configuration

• Failure Point: Bazel build step when processing Go toolchain configuration

• Root Cause Analysis:
The Go version format in go.mod is incorrect. Go modules require version strings in format "1.XX", but the current version string includes the patch version "1.23.4"

• Suggested Fix:

  1. Remove patch version from go.mod version
  2. Add a step before the bazel build to fix the go.mod:
  - name: Fix Go version format
    runs: |
      sed -i 's/go 1.23.4/go 1.23/' go.mod

• Explanation:
The Go toolchain is strict about version format in go.mod files. While the installed Go version can be 1.23.4, the go.mod must specify only major.minor (1.23). This fix will make the version format compatible with Go's requirements while maintaining the same Go version compatibility.

• Additional Notes:

  • This is a common issue when using Go in bazel builds
  • The fix maintains the same Go version compatibility while adhering to go.mod formatting rules
  • Consider adding this as a standard step for similar builds that mix Go and Bazel

• References:

Signed-off-by: Ajay Kemparaj <[email protected]>
@ajayk ajayk enabled auto-merge (squash) December 24, 2024 19:19
@ajayk ajayk merged commit 2825e0b into main Dec 24, 2024
14 checks passed
@ajayk ajayk deleted the cve-cilium-envoy-1.16-8de313b0cfe68a1c4b166e078b13f134 branch December 24, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants