Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-3.4/3.4.1 package update #38335

Merged
merged 4 commits into from
Dec 26, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 25, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Dec 25, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 25, 2024

Gen AI suggestions to solve the build error:

Based on the build error and the provided Melange YAML file, I can analyze the issue:

• Detected Error: No explicit error message is shown, but the build appears to fail when trying to checkout the source code due to an invalid tag reference.

• Error Category: Version/Tag Configuration

• Failure Point: git-checkout pipeline step

• Root Cause Analysis: The tag reference v${{vars.underscore-package-version}}_preview2 is incorrect for Ruby 3.4.1. The current version is not a preview release.

• Suggested Fix:

  1. Update the git-checkout block to use the correct tag format:
  - uses: git-checkout
    with:
      repository: https://github.com/ruby/ruby
      tag: v3_4_1
      expected-commit: b42e2d2b15e3c2adc93f8b4f979eaee8b87b8c8c  # Update this to match the actual commit

• Explanation:

  • Ruby's release tags follow the pattern v3_4_1 for stable releases
  • The current configuration is trying to fetch a preview version which doesn't exist
  • Ruby 3.4.1 is a stable release, not a preview release
  • The underscore transformation is not needed as Ruby uses underscores in their tags directly

• Additional Notes:

  • Ruby's versioning scheme uses underscores in tags rather than dots
  • Preview releases are only used during development phase
  • The expected-commit hash should be updated to match the actual release commit

• References:

Copy link
Contributor Author

octo-sts bot commented Dec 25, 2024

Gen AI suggestions to solve the build error:

Based on the error logs, I'll analyze and provide a solution:

• Detected Error:

fatal: Remote branch v3_4_1 not found in upstream origin

(This error is implied by the git checkout failure)

• Error Category: Version/Configuration

• Failure Point:
Pipeline step "git-checkout" when trying to clone the repository with tag v3_4_1

• Root Cause Analysis:
The build is failing because the git tag format in the pipeline doesn't match Ruby's actual tag format. Ruby uses 'v3.4.1' not 'v3_4_1' for their tags.

• Suggested Fix:
Modify the var-transforms section in the YAML to correctly handle Ruby's tag format:

var-transforms:
  - from: ${{package.version}}
    match: \.
    replace: .
    to: package-version

And update the git-checkout section to use:

  - uses: git-checkout
    with:
      repository: https://github.com/ruby/ruby
      tag: v${{vars.package-version}}
      expected-commit: 48d4efcb85000e1ebae42004e963b5d0cedddcf2

• Explanation:
Ruby's official release tags use dots (.) rather than underscores (_). The current transform is converting 3.4.1 to 3_4_1, but Ruby's actual tag is v3.4.1. This fix removes the underscore transformation and uses the version number directly.

• Additional Notes:

  • The commit hash appears correct for Ruby 3.4.1
  • Ruby's tagging convention consistently uses dots rather than underscores
  • This is a common pattern when dealing with Ruby version updates

• References:

@Dentrax Dentrax self-assigned this Dec 25, 2024
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 25, 2024
@Dentrax Dentrax enabled auto-merge (squash) December 25, 2024 17:46
@Dentrax Dentrax merged commit 6168e0f into main Dec 26, 2024
14 checks passed
@Dentrax Dentrax deleted the wolfictl-c8f9c814-8d9a-4a6a-ae7e-f93d2b7f4bef branch December 26, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants