Skip to content

Commit

Permalink
remove domain from directory query params (#259)
Browse files Browse the repository at this point in the history
  • Loading branch information
ameesha authored Jun 6, 2024
1 parent c3d70ba commit 519531a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 25 deletions.
2 changes: 0 additions & 2 deletions lib/workos/directory_sync.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ class << self
# Retrieve directories.
#
# @param [Hash] options An options hash
# @option options [String] domain The domain of the directory to be
# retrieved.
# @option options [String] search A search term for direcory names.
# @option options [String] limit Maximum number of records to return.
# @option options [String] order The order in which to paginate records
Expand Down
23 changes: 0 additions & 23 deletions spec/lib/workos/directory_sync_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,29 +20,6 @@
end
end

context 'with domain option' do
it 'forms the proper request to the API' do
request_args = [
'/directories?domain=foo-corp.com&'\
'order=desc',
'Content-Type' => 'application/json'
]

expected_request = Net::HTTP::Get.new(*request_args)

expect(Net::HTTP::Get).to receive(:new).with(*request_args).
and_return(expected_request)

VCR.use_cassette 'directory_sync/list_directories/with_domain' do
directories = described_class.list_directories(
domain: 'foo-corp.com',
)

expect(directories.data.size).to eq(1)
end
end
end

context 'with search option' do
it 'forms the proper request to the API' do
request_args = [
Expand Down

0 comments on commit 519531a

Please sign in to comment.