Development #1
Merged
Development #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Emit types using tsc
* Update deprecated code
* move lib to src * path updates - as suggested by @johnhooks to set as source for tests the "src" folder (and not the builded one) - updated node internal modules paths prefix (ref. https://nodejs.org/api/module.html#modules-nodemodule-api) * typescript file compilation config
* speed up lexer parsing
- scripts - make sure that all is ready before fire the script
* fix missing types and jsDocs * removing definition file, the definitions were moved to the type.js file * enhanced type for pocompiler and postream * enhancing js docs types * jsdocs types (still few error to solve) * @johnhooks review suggestions Co-authored-by: John Hooks <[email protected]> * apply suggestion by johnhooks Co-authored-by: John Hooks <[email protected]> * apply @johnhooks suggestions 🙌 * wip types * fixed types * allows tsc to fail in ci tests * fix: adjust typing of the parsers and compilers This commit adds missing types and attempts fix type errors. There are still a few type errors, though how to fix them is not clear. Adds the `Translations` type for the `translations` property of the `GetTextTranslations` type. * add imports for types * add encoding declaration * add types directory to tsconfig include * remove types directory from .gitignore --------- Co-authored-by: John Hooks <[email protected]>
* track coverage using c8 * Fix: tests runs twice
The escape character logic was not working correctly. The logic of how a line is folded with a final escape character was flawed. Using a loop to consume forward slashes would not allow for an escaped forward slash to be folded correctly, it would append an extra character to the line. - Use if statements to check for escape characters. Only one extra character should be appended to the line, and it should be considered escaped. - Add new test cases to test the escape character logic.
fix: foldLine escape character logic
* feat: add support for compiling big-endian .mo files This commit adds support for compiling big-endian .mo files. This facilitates the use of .mo files in big-endian systems, the ability to parser big-endian .mo files was already present. This commit also does the following: - Adds a new mo parser options type, used to indicate `endian = 'le' | 'be'` - Adds tests and fixtures for big-endian .mo files. - Renames the existing .mo fixtures to indicate that they are little-endian. - Fixes direct usages of `writeUInt32LE`. Fixes smhg#97
Tests for shared.js
johnhooks
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's restart here