Skip to content

chore: Created admin functionality for displaying and saving data #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: Created admin functionality for displaying and saving data #384

wants to merge 8 commits into from

Conversation

colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Aug 20, 2025 •
edited
Loading

Description

This PR focuses on creating the admin functionality around displaying and saving configuration.

The initial PR creates configuration for Basic Configuration but we expect to add more tabs as we progress the logging plugin.

Note

A follow on PR will be created to integrate these settings into the plugin.

Related Issue

#353

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Screenshot 2025-08-20 at 17 56 54 Screenshot 2025-08-20 at 17 57 25

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@colinmurphy
Merge branch 'main' into chore-add-admin-functionality-wpgraphql-logging
add5381
@colinmurphy
Initial creation of the admin functionality. Added config for basic c…
fe33b7c 
…onfiguration.
@colinmurphy
Improve settings field sanitization and add tests
810a5ac 
Refactored Select_Field sanitization to handle non-string values and filter out invalid options. Removed redundant is_admin() check in Settings_Page::init. Added comprehensive unit tests for Settings_Page to verify initialization, hook registration, tab selection, and asset loading behaviors.
@colinmurphy
Document and extend admin settings architecture
2a0087e 
Added detailed admin settings documentation in docs/admin.md and updated README.md with references to admin architecture and extension hooks. Modified Basic_Configuration_Tab to allow fields to be filtered via 'wpgraphql_logging_basic_configuration_fields', enabling easier extension of admin settings.
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8dfeeef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

ℹ️ Download the latest wpgraphql-logging plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@colinmurphy colinmurphy marked this pull request as ready for review August 20, 2025 16:58
@colinmurphy colinmurphy requested a review from a team as a code owner August 20, 2025 16:58
@colinmurphy
Disable SSL mode for MySQL commands in test env script
4ce8dca 
Adds --ssl-mode=DISABLED to mysql and mysqladmin commands in install-test-env.sh to prevent SSL connection issues during database setup.
@colinmurphy
Update install-test-env.sh
18ab11e
@colinmurphy
Reverted change as it didn't fix the issue.
8dfeeef
@colinmurphy colinmurphy mentioned this pull request Aug 21, 2025
Open
@josephfusco
Copy link
Member

@colinmurphy The latest zip is failing to activate in a new WordPress install. It could just be a plugin error preventing activation. I tried an earlier version of the zip but the same thing happened.

There might be something going on with just the activation step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinmurphy @josephfusco